Re: [minor patch] exit_files()/exit_mm() -> NULL vs &init_xx

Nicholas Henke (henken@seas.upenn.edu)
Sat, 01 May 1999 21:27:54 -0500


Andrea Arcangeli wrote:
>
> Considered the previous changes probably it's nicer to change also this
> (even if setting tsk->files in copy_files() currently it's not needed and
> could be safely avoided).
>
> Index: kernel/fork.c
> ===================================================================
> RCS file: /var/cvs/linux/kernel/fork.c,v
> retrieving revision 1.1.2.20
> diff -u -r1.1.2.20 fork.c
> --- fork.c 1999/04/17 23:40:26 1.1.2.20
> +++ linux/kernel/fork.c 1999/05/02 00:13:45
> @@ -453,7 +453,7 @@
> goto out;
> }
>
> - tsk->files = NULL;
> + tsk->files = &init_files;
> error = -ENOMEM;
> newf = kmem_cache_alloc(files_cachep, SLAB_KERNEL);
> if (!newf)
>
> Andrea Arcangeli
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
> Please read the FAQ at http://www.tux.org/lkml/
I have been running your patches, and I have to say that I am noticing a
imporvment in memory management. What tests should I run so that I may
supply you with info that is helpfull. Thanks
Nic
-- 
Nicholas Henke
University of Pennsylvania 
Class of 2002
215-417-5665
(ht/ft)tp://bs28-222-095.resnet.upenn.edu
----------------------
Clothes make the man.  Naked people have little or no influence on
society.
		-- Mark Twain

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/