Re: [PATCH] Capabilities in elf

Jakub Jelinek (jj@sunsite.ms.mff.cuni.cz)
Thu, 15 Apr 1999 00:14:37 +0200 (CEST)


>
> Hi!
>
> Here is next version, this one is believed NOT to contain security
> hole. Please take a look, and comment i.e. post me things like "GREAT!
> this is going to be included in 2.2.6".

Few comments:
FPUCW does not have to be exported to userland, unless it changes from the
defaults glibc is aware of for the different architectures. That's how it
has been decided between Linus and Ulrich, so there is no need to muck with
that in your patch.
Allocating such low PT_* value is really asking for trouble. One should use
some high PT_* value in the allowable range.
I don't think Linus will take the patch if you accept there \x7fFLE as magic,
it is really a hackish solution. No userland program will be able to cope
with such executables.
And of course, you'd need to remove all those printks from there to actually
send it to Linus anyway.

Cheers,
Jakub
___________________________________________________________________
Jakub Jelinek | jj@sunsite.mff.cuni.cz | http://sunsite.mff.cuni.cz
Administrator of SunSITE Czech Republic, MFF, Charles University
___________________________________________________________________
UltraLinux | http://ultra.linux.cz/ | http://ultra.penguin.cz/
Linux version 2.2.5 on a sparc64 machine (3958.37 BogoMips)
___________________________________________________________________

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/