Printks without log level [originally: Re: superblock help [PATCH for fat]]

Philipp Thomas (kthomas@gwdg.de)
Tue, 13 Apr 1999 23:02:43 GMT


On Thu, 1 Apr 1999 13:19:00 +0200 (MET DST), you wrote:

>+ printk("Funny: clusters+2=%d fat_clusters=%d\n",
>+ MSDOS_SB(sb)->clusters+2, fat_clusters);

Sorry to pick you Andries, but could at least those of you who add printks
_please_ use an appropriate log level, it's bad enough that so much existing
code ignores them.

Call me silly or tell me that I'm doing needless work, but I try to check that
the code that's actually compiled into my kernel or the modules I need/use do
use log levels in order to make it possible for syslogd to obey my
configuration, which for me most prominently means 'echo info level stuff
only to var/log/messages and /dev/tty12'.

And while I only can blame myself for not having forwarded the changes to the
respective maintainers, I think is the right thing to request what I do.

Just to make it clear (as english isn't my native tongue and as I know of the
problems of mail based communication, I'm not always sure I do express myself
appropriately), I don't intend to flame you or anybody else but rather appeal
that this be changed.

Philipp Thomas

-- 
caffeine low .... brain halted

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/