Re: Filesystem specific information in inode overwritten

Alexander Viro (viro@math.psu.edu)
Thu, 4 Feb 1999 16:58:50 -0500 (EST)


On Thu, 4 Feb 1999, Mikulas Patocka wrote:

> > > Look at unit 'u' in inode structure in fs.h
> > > You see that pipe_inode_info and socket share space with filesystem
> > > specific information.
> >
> > Ah, one more person who noticed this lossage. Welcome to the club. I've
> > sent the fix, but it was waay too close to 2.2.0, so... Linus told that
> > while it looked OK for 2.3 it was *not* a 2.2-pre material.
>
> So I'll have to add 'char bug_workaround[64]' at the beginning of
> struct hpfs_inode_info. Grrrr.

Grrrr, indeed. I tripped over that stuff when I tried to separate
fs-dependent part of inode from inode itself (ext2; works). It also screws
NTFS folks. It also adds uglyness to FAT-derived filesystems and NFS.
Pity that I noticed it too late and those who've met this bug before just
added bandaids instead of fixing the thing. Please, surround the
placeholder with #if LINUX_VERSION_CODE < 0x20300 and
#else
#error Fix the FIFO stuff
#endif
so that it would scream and shout in 2.3, OK?
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/