plip.c and transmit timeout madness

Shaun Wilson (plexus@ionet.net)
Thu, 28 Jan 1999 01:02:39 -0600 (CST)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

---559023410-758783491-917506959=:211
Content-Type: TEXT/PLAIN; charset=US-ASCII

Using the same setup (concearning plip) I've had since 2.1.117 I'm having
problems with 2.2.0 which i finally decided to install this morning. All's
well, disk access is smooth, et cetera.

but when i bring my plip interface up it only functions for a small time
before my console is flooded with "transmit timout(1,80)".

I have encountered this problem in past kernels (last september) and since
then I have been using my own patch to get rid of it, only with 2.2.0
there are two additional issues:

1) The drivers/net/plip.c source has been modified since I developed the
patch and no longer cleanly applies.
2) After re-implmenting most of teh patch (all except for the portion
which defaults net_debug to 0 instead of 1, thus removing the messages
altogether) in a more 'congruent with kernel net_debug' manner the message
snot only continue to appear, but worse, now the interface is dead, no
traffic in and no traffic out.

I've spent from 8am till now trying to figure out why and it eludes me.
attatched are two patches. the first addresses irq handling (actually
redundancy in irq handling that i pointed out last spetember) and teh
second will patch plip.c with irq fix and it addresses the fact that
net_debug 2 was being ignored throughout the plip.c source.

It seems taht for whatever reason teh first patch extends teh time which
teh interface remains functional, oterh than that, I'm at a loss because I
can't see anything besides two macros and a new HS_TIMEOUT define that is
new to plip.c

I've emailed the maintainer before(gniibe@*.jp) and received no response,
so if anyone knows what the purpose behind HS_TIMEOUT is please fill me
in, afaik it's nothing more than a method of capturing a timeout specific
to the transmit operation, which would also be my problem.

---559023410-758783491-917506959=:211
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="plip.c-diff-ely2"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.3.96.990128010239.211B@ultra5>
Content-Description:

LS0tIHBsaXAuYy1vbGQtZWx5MQlXZWQgSmFuIDI3IDIzOjE3OjI0IDE5OTkN
CisrKyBwbGlwLmMJV2VkIEphbiAyNyAyMzoyMDozMCAxOTk5DQpAQCAtMjcs
NiArMjcsOCBAQA0KICAqDQogICoJCUVseSBXaWxzb24NCiAgKgkJICAtIEZp
eGVkIGFsbCBjYWxscyB0byBzeW5jaHJvbml6ZV9pcnEoKSBhcyBzdWdnZXN0
ZWQgU2VwdDk4DQorICoJCSAgLSBTb21lIGlmICgpIHN0YXRlbWVudHMgd2Vy
ZSBpZ25vcmluZyBwcm9wb3NlZCBuZXRfZGVidWcNCisgKgkJICAgIGxldmVs
cy4gDQogICoNCiAgKg0KICAqCQlUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0
d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yDQpAQCAtMTIy
LDcgKzEyNCw3IEBADQogLyogTWF4aW11bSBudW1iZXIgb2YgZGV2aWNlcyB0
byBzdXBwb3J0LiAqLw0KICNkZWZpbmUgUExJUF9NQVggIDgNCiANCi0vKiBV
c2UgMCBmb3IgcHJvZHVjdGlvbiwgMSBmb3IgdmVyaWZpY2F0aW9uLCA+MiBm
b3IgZGVidWcgKi8NCisvKiBVc2UgMCBmb3IgcHJvZHVjdGlvbiwgMSBmb3Ig
dmVyaWZpY2F0aW9uLCA+PTIgZm9yIGRlYnVnICovDQogI2lmbmRlZiBORVRf
REVCVUcNCiAjZGVmaW5lIE5FVF9ERUJVRyAxDQogI2VuZGlmDQpAQCAtNTI2
LDcgKzUyOCw3IEBADQogCQlvdXRiKFBBUl9JTlRSX09GRiwgUEFSX0NPTlRS
T0woZGV2KSk7DQogCQlkZXYtPmludGVycnVwdCA9IDA7DQogCQlvdXRiKDB4
MDEsIFBBUl9EQVRBKGRldikpOyAvKiBzZW5kIEFDSyAqLw0KLQkJaWYgKG5l
dF9kZWJ1ZyA+IDIpDQorCQlpZiAobmV0X2RlYnVnID4gMSkNCiAJCQlwcmlu
dGsoS0VSTl9ERUJVRyAiJXM6IHJlY2VpdmUgc3RhcnRcbiIsIGRldi0+bmFt
ZSk7DQogCQlyY3YtPnN0YXRlID0gUExJUF9QS19MRU5HVEhfTFNCOw0KIAkJ
cmN2LT5uaWJibGUgPSBQTElQX05CX0JFR0lOOw0KQEAgLTYwMyw3ICs2MDUs
NyBAQA0KIAkJbmwtPmVuZXRfc3RhdHMucnhfYnl0ZXMgKz0gcmN2LT5sZW5n
dGguaDsNCiAJCW5sLT5lbmV0X3N0YXRzLnJ4X3BhY2tldHMrKzsNCiAJCXJj
di0+c2tiID0gTlVMTDsNCi0JCWlmIChuZXRfZGVidWcgPiAyKQ0KKwkJaWYg
KG5ldF9kZWJ1ZyA+IDEpDQogCQkJcHJpbnRrKEtFUk5fREVCVUcgIiVzOiBy
ZWNlaXZlIGVuZFxuIiwgZGV2LT5uYW1lKTsNCiANCiAJCS8qIENsb3NlIHRo
ZSBjb25uZWN0aW9uLiAqLw0KQEAgLTcyNyw3ICs3MjksNyBAQA0KIAkJCQkJ
cmV0dXJuIE9LOw0KIAkJCQl9DQogCQkJCW91dGIoUEFSX0lOVFJfT0ZGLCBQ
QVJfQ09OVFJPTChkZXYpKTsNCi0JCQkJaWYgKG5ldF9kZWJ1ZyA+IDIpDQor
CQkJCWlmIChuZXRfZGVidWcgPiAxKQ0KIAkJCQkJcHJpbnRrKEtFUk5fREVC
VUcgIiVzOiBzZW5kIHN0YXJ0XG4iLCBkZXYtPm5hbWUpOw0KIAkJCQlzbmQt
PnN0YXRlID0gUExJUF9QS19MRU5HVEhfTFNCOw0KIAkJCQlzbmQtPm5pYmJs
ZSA9IFBMSVBfTkJfQkVHSU47DQpAQCAtNzgwLDcgKzc4Miw3IEBADQogCQkv
KiBDbG9zZSB0aGUgY29ubmVjdGlvbiAqLw0KIAkJb3V0YiAoMHgwMCwgZGF0
YV9hZGRyKTsNCiAJCXNuZC0+c2tiID0gTlVMTDsNCi0JCWlmIChuZXRfZGVi
dWcgPiAyKQ0KKwkJaWYgKG5ldF9kZWJ1ZyA+IDEpDQogCQkJcHJpbnRrKEtF
Uk5fREVCVUcgIiVzOiBzZW5kIGVuZFxuIiwgZGV2LT5uYW1lKTsNCiAJCW5s
LT5jb25uZWN0aW9uID0gUExJUF9DTl9DTE9TSU5HOw0KIAkJbmwtPmlzX2Rl
ZmVycmVkID0gMTsNCkBAIC04MTksNyArODIxLDcgQEANCiANCiAJc3RhdHVz
ID0gaW5iKFBBUl9TVEFUVVMoZGV2KSk7DQogCWlmICgoc3RhdHVzICYgMHhm
OCkgPT0gMHg4MCkgew0KLQkJaWYgKG5ldF9kZWJ1ZyA+IDIpDQorCQlpZiAo
bmV0X2RlYnVnID4gMSkNCiAJCQlwcmludGsoS0VSTl9ERUJVRyAiJXM6IHJl
c2V0IGludGVyZmFjZS5cbiIsIGRldi0+bmFtZSk7DQogCQlubC0+Y29ubmVj
dGlvbiA9IFBMSVBfQ05fTk9ORTsNCiAJCW5sLT5zaG91bGRfcmVsaW5xdWlz
aCA9IDA7DQpAQCAtODYzLDcgKzg2NSw3IEBADQogCQlyZXR1cm47DQogCX0N
CiAJZGV2LT5pbnRlcnJ1cHQgPSAxOw0KLQlpZiAobmV0X2RlYnVnID4gMykN
CisJaWYgKG5ldF9kZWJ1ZyA+IDIpDQogCQlwcmludGsoS0VSTl9ERUJVRyAi
JXM6IGludGVycnVwdC5cbiIsIGRldi0+bmFtZSk7DQogDQogCXNwaW5fbG9j
a19pcnEoJm5sLT5sb2NrKTsNCkBAIC05MzgsNyArOTQwLDcgQEANCiAJCXJl
dHVybiAwOw0KIAl9DQogDQotCWlmIChuZXRfZGVidWcgPiAyKQ0KKwlpZiAo
bmV0X2RlYnVnID4gMSkNCiAJCXByaW50ayhLRVJOX0RFQlVHICIlczogc2Vu
ZCByZXF1ZXN0XG4iLCBkZXYtPm5hbWUpOw0KIA0KIAlzcGluX2xvY2tfaXJx
KCZubC0+bG9jayk7DQo=
---559023410-758783491-917506959=:211
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="plip.c-diff-ely1"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.GSO.3.96.990128010239.211C@ultra5>
Content-Description:

LS0tIHBsaXAuYy4yMjAJV2VkIEphbiAyNyAwODozNjozNSAxOTk5DQorKysg
cGxpcC5jCVdlZCBKYW4gMjcgMjM6MDU6MzkgMTk5OQ0KQEAgLTI1LDYgKzI1
LDEwIEBADQogICoJCSAgLSBDaGFuZ2VkIHtlbmFibGUsZGlzYWJsZX1faXJx
IGhhbmRsaW5nIHRvIG1ha2UgaXQgd29yaw0KICAqCQkgICAgd2l0aCBuZXcg
KCJzdGFjayIpIHNlbWFudGljcy4NCiAgKg0KKyAqCQlFbHkgV2lsc29uDQor
ICoJCSAgLSBGaXhlZCBhbGwgY2FsbHMgdG8gc3luY2hyb25pemVfaXJxKCkg
YXMgc3VnZ2VzdGVkIFNlcHQ5OA0KKyAqDQorICoNCiAgKgkJVGhpcyBwcm9n
cmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0
IGFuZC9vcg0KICAqCQltb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo
ZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQ0KICAqCQlhcyBwdWJsaXNo
ZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZl
cnNpb24NCkBAIC00MzYsMTEgKzQ0MCwxMSBAQA0KIAkJZGV2X2tmcmVlX3Nr
YihzbmQtPnNrYik7DQogCQlzbmQtPnNrYiA9IE5VTEw7DQogCX0NCisNCiAJ
c3Bpbl91bmxvY2tfaXJxKCZubC0+bG9jayk7DQotCWlmIChlcnJvciA9PSBI
U19USU1FT1VUKSB7DQorCWlmIChlcnJvciA9PSBIU19USU1FT1VUKQ0KIAkJ
RElTQUJMRShkZXYtPmlycSk7DQotCQlzeW5jaHJvbml6ZV9pcnEoKTsNCi0J
fQ0KKw0KIAlvdXRiKFBBUl9JTlRSX09GRiwgUEFSX0NPTlRST0woZGV2KSk7
DQogCWRldi0+dGJ1c3kgPSAxOw0KIAlubC0+Y29ubmVjdGlvbiA9IFBMSVBf
Q05fRVJST1I7DQpAQCAtNTE5LDcgKzUyMyw2IEBADQogCXN3aXRjaCAocmN2
LT5zdGF0ZSkgew0KIAljYXNlIFBMSVBfUEtfVFJJR0dFUjoNCiAJCURJU0FC
TEUoZGV2LT5pcnEpOw0KLQkJLyogRG9uJ3QgbmVlZCB0byBzeW5jaHJvbml6
ZSBpcnEsIGFzIHdlIGNhbiBzYWZlbHkgaWdub3JlIGl0ICovDQogCQlvdXRi
KFBBUl9JTlRSX09GRiwgUEFSX0NPTlRST0woZGV2KSk7DQogCQlkZXYtPmlu
dGVycnVwdCA9IDA7DQogCQlvdXRiKDB4MDEsIFBBUl9EQVRBKGRldikpOyAv
KiBzZW5kIEFDSyAqLw0KQEAgLTcxMiw3ICs3MTUsNiBAQA0KIAkJCWlmIChj
MCAmIDB4MDgpIHsNCiAJCQkJc3Bpbl91bmxvY2tfaXJxKCZubC0+bG9jayk7
DQogCQkJCURJU0FCTEUoZGV2LT5pcnEpOw0KLQkJCQlzeW5jaHJvbml6ZV9p
cnEoKTsNCiAJCQkJaWYgKG5sLT5jb25uZWN0aW9uID09IFBMSVBfQ05fUkVD
RUlWRSkgew0KIAkJCQkJLyogSW50ZXJydXB0ZWQuDQogCQkJCQkgICBXZSBk
b24ndCBuZWVkIHRvIGVuYWJsZSBpcnEsDQpAQCAtMTAyNSw3ICsxMDI3LDYg
QEANCiAJZGV2LT50YnVzeSA9IDE7DQogCWRldi0+c3RhcnQgPSAwOw0KIAlE
SVNBQkxFKGRldi0+aXJxKTsNCi0Jc3luY2hyb25pemVfaXJxKCk7DQogDQog
I2lmZGVmIE5PVERFRg0KIAlvdXRiKDB4MDAsIFBBUl9EQVRBKGRldikpOw0K

---559023410-758783491-917506959=:211--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/