--1421910094-1228150175-914933099=:15221
Content-Type: TEXT/PLAIN; charset=US-ASCII
Hi Michael.
> I took a close look at your patch:
> bool 'Networking support' CONFIG_NET
> bool 'PCI support' CONFIG_PCI
> if [ "$CONFIG_PCI" = "y" ]; then
> - bool ' PCI BIOS support' CONFIG_PCI_BIOS
> - bool ' PCI direct access support' CONFIG_PCI_DIRECT
> - if [ "$CONFIG_PCI_BIOS" = "n" -a "$CONFIG_PCI_DIRECT" = "n" ]; then
> + unset CONFIG_PCI_BIOS CONFIG_PCI_DIRECT
> + choice 'PCI access mode' \
> + "BIOS CONFIG_PCI_GOBIOS \
> + Direct CONFIG_PCI_GODIRECT \
> + Any CONFIG_PCI_GOANY" Any
> + if [ -n "$CONFIG_PCI_GOBIOS" -o -n "$CONFIG_PCI_GOANY" ]; then
> define_bool CONFIG_PCI_BIOS y
> + fi
> + if [ -n "$CONFIG_PCI_GODIRECT" -o -n "$CONFIG_PCI_GOANY" ]; then
> + define_bool CONFIG_PCI_DIRECT y
> fi
> Will you please test your code on your own damn machine before you
> send it to Linus with cc: to linux-kernel?
I did - obviously not very well, but that doesnae mean it went
untested...
In addition, I can clearly state that it was sent to Linus because it
was developed for him at HIS request - that part of the config files
holds little interest to me, and I wouldnae have looked at it had not
Linus and Alan referred to problems with it...
> And if you are going to write Config.in code, stay the hell away
> from features that no other Config.in file uses. You are asking for
> bugs and they are occurring.
Would you have handy a list of the "features that no other Config.in
file uses" that you refer to? I don't...
> This code doesn't work on xconfig, ok fine, xconfig is the black
> sheep configuration method anyways. We will make xconfig work, one
> way or another.
> But your code doesn't work in make configure.
> It doesn't work in make oldconfig.
> It doesn't work in make menuconfig.
> In all of these configuration methods, it always sets both
> CONFIG_PCI_BIOS and CONFIG_PCI_DIRECT, no matter what choice the
> user selects.
> Did you notice that?
I have to admit that I hadn't noticed that - when I tried it out on my
system and examined the resultant .config file from "make menuconfig",
it looked correct, so I obviously overlooked something here...
I've just rechecked, and as you state, it doesn't work! Sorry.
> Did you spend even 10 minutes testing your code before sending it
> to Linus?
About 20 minutes was spent testing it, but I somehow managed to
overlook that particular fault...for which I apologise...
> (By the way, the reason -n doesn't work for choice list items is
> actually documented in the history comments of Menuconfig.
I'm looking at the said comments in another window on my x-screen
right now, and I have to admit to defeat in finding the documentation
you refer to.
The only one that bears any relation to this point would appear to be
the comment dated 131197, which basically states that a line of output
is produced for each of the options in a choice list. I had assumed
such to be the case, with the usual "option=y" for the selected
option, and comments for the remaining options, and I see this is
indeed the case in the .config file produced. As a result, it implies
that the -n construct I used SHOULD work, although quite obviously it
doesn't...
> Menuconfig has behaved this way since 13 November 1997. Configure
> has *always* behaved this way.)
Nods...and thanks for clearing up my misunderstanding of how that
works...
For reference, a corrected version thereof is enclosed with this
email...perhaps you could check this one out and advise whether it
works or not?
Best wishes from Riley.
--1421910094-1228150175-914933099=:15221
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="PCI.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.981229120459.15221G@ps.cus.umist.ac.uk>
Content-Description:
LS0tIGxpbnV4L2FyY2gvaTM4Ni9jb25maWcuaW4ub3JpZwlGcmkgRGVjIDE4
IDIyOjAxOjQ4IDE5OTgNCisrKyBsaW51eC9hcmNoL2kzODYvY29uZmlnLmlu
CVdlZCBEZWMgMjMgMjI6MTU6NDEgMTk5OA0KQEAgLTM2LDE0ICszNiwyMCBA
QA0KIGNvbW1lbnQgJ0dlbmVyYWwgc2V0dXAnDQogDQogYm9vbCAnTmV0d29y
a2luZyBzdXBwb3J0JyBDT05GSUdfTkVUDQogYm9vbCAnUENJIHN1cHBvcnQn
IENPTkZJR19QQ0kNCiBpZiBbICIkQ09ORklHX1BDSSIgPSAieSIgXTsgdGhl
bg0KLSAgYm9vbCAnICAgUENJIEJJT1Mgc3VwcG9ydCcgQ09ORklHX1BDSV9C
SU9TDQotICBib29sICcgICBQQ0kgZGlyZWN0IGFjY2VzcyBzdXBwb3J0JyBD
T05GSUdfUENJX0RJUkVDVA0KLSAgaWYgWyAiJENPTkZJR19QQ0lfQklPUyIg
PSAibiIgLWEgIiRDT05GSUdfUENJX0RJUkVDVCIgPSAibiIgXTsgdGhlbg0K
LSAgICBkZWZpbmVfYm9vbCBDT05GSUdfUENJX0JJT1MgInkiDQorICB1bnNl
dCBDT05GSUdfUENJX0JJT1MgQ09ORklHX1BDSV9ESVJFQ1QNCisgIGNob2lj
ZSAnUENJIGFjY2VzcyBtb2RlJyBcDQorCSJCSU9TCQlDT05GSUdfUENJX0dP
QklPUwlcDQorCSBEaXJlY3QJCUNPTkZJR19QQ0lfR09ESVJFQ1QJXA0KKwkg
QW55CQlDT05GSUdfUENJX0dPQU5ZIglBbnkNCisgIGlmIFsgIiRDT05GSUdf
UENJX0dPQklPUyIgPSAieSIgLW8gIiRDT05GSUdfUENJX0dPQU5ZIiA9ICJ5
IiBdOyB0aGVuDQorICAgIGRlZmluZV9ib29sIENPTkZJR19QQ0lfQklPUyB5
DQorICBmaQ0KKyAgaWYgWyAiJENPTkZJR19QQ0lfR09ESVJFQ1QiID0gInki
IC1vICIkQ09ORklHX1BDSV9HT0FOWSIgPSAieSIgXTsgdGhlbg0KKyAgICBk
ZWZpbmVfYm9vbCBDT05GSUdfUENJX0RJUkVDVCB5DQogICBmaQ0KICAgYm9v
bCAnICAgUENJIHF1aXJrcycgQ09ORklHX1BDSV9RVUlSS1MNCiAgIGlmIFsg
IiRDT05GSUdfUENJX1FVSVJLUyIgPSAieSIgLWEgIiRDT05GSUdfRVhQRVJJ
TUVOVEFMIiA9ICJ5IiBdOyB0aGVuDQogICAgIGJvb2wgJyAgIFBDSSBicmlk
Z2Ugb3B0aW1pemF0aW9uIChleHBlcmltZW50YWwpJyBDT05GSUdfUENJX09Q
VElNSVpFDQogICBmaQ0KLS0tIGxpbnV4L0RvY3VtZW50YXRpb24vQ29uZmln
dXJlLmhlbHAub3JpZwlUdWUgRGVjIDIyIDE2OjI5OjAwIDE5OTgNCisrKyBs
aW51eC9Eb2N1bWVudGF0aW9uL0NvbmZpZ3VyZS5oZWxwCVNhdCBEZWMgMjYg
MTU6NDE6MDUgMTk5OA0KQEAgLTEyOTEsMzAgKzEyOTEsNDMgQEANCiANCiAg
IElmIHNvbWUgb2YgeW91ciBQQ0kgZGV2aWNlcyBkb24ndCB3b3JrIGFuZCB5
b3UgZ2V0IGEgd2FybmluZyBkdXJpbmcNCiAgIGJvb3QgdGltZSAoIm1hbiBk
bWVzZyIpLCBwbGVhc2UgZm9sbG93IHRoZSBpbnN0cnVjdGlvbnMgYXQgdGhl
IHRvcA0KICAgb2YgaW5jbHVkZS9saW51eC9wY2kuaC4NCiANCi1QQ0kgQklP
UyBzdXBwb3J0DQotQ09ORklHX1BDSV9CSU9TDQotICBJZiB5b3UgaGF2ZSBl
bmFibGVkIFBDSSBidXMgc3VwcG9ydCBhYm92ZSwgeW91IHByb2JhYmx5IHdh
bnQgdG8NCi0gIGFsbG93IExpbnV4IHRvIHVzZSB5b3VyIFBDSSBCSU9TIHRv
IGRldGVjdCB0aGUgUENJIGRldmljZXMgYW5kDQotICBkZXRlcm1pbmUgdGhl
aXIgY29uZmlndXJhdGlvbi4gTm90ZTogc29tZSBvbGQgUENJIG1vdGhlcmJv
YXJkcyBoYXZlDQotICBCSU9TIGJ1Z3MgYW5kIG1heSBjcmFzaCBpZiB5b3Ug
c2F5IFkgaGVyZSAtLSBmb3Igc3VjaCBtb3RoZXJib2FyZHMsDQotICB5b3Ug
c2hvdWxkIHNheSBOIGhlcmUgYW5kIHNheSBZIHRvICJQQ0kgZGlyZWN0IGFj
Y2VzcyBzdXBwb3J0Ig0KLSAgaW5zdGVhZC4NCi0NCi0gIEV4Y2VwdCBmb3Ig
c29tZSBzcGVjaWFsIGNhc2VzIChlbWJlZGRlZCBzeXN0ZW1zIHdpdGggbm8g
QklPUyksIHlvdQ0KLSAgcHJvYmFibHkgc2hvdWxkIHNheSBZIGhlcmUuDQot
DQotUENJIGRpcmVjdCBhY2Nlc3Mgc3VwcG9ydA0KLUNPTkZJR19QQ0lfRElS
RUNUDQotICBJZiB5b3UgZG9uJ3Qgd2FudCB0byB1c2UgdGhlIFBDSSBCSU9T
IChlLmcuLCBiZWNhdXNlIHlvdSBydW4gc29tZQ0KLSAgZW1iZWRkZWQgc3lz
dGVtIHdpdGggbm8gQklPUyBhdCBhbGwpIG9yIExpbnV4IHNheXMgaXQgY2Fu
bm90IHVzZQ0KLSAgeW91ciBQQ0kgQklPUywgeW91IGNhbiBlbmFibGUgZGly
ZWN0IFBDSSBoYXJkd2FyZSBoZXJlLiBJdCBtaWdodA0KLSAgZmFpbCBpZiB5
b3VyIG1hY2hpbmUgaXMgYmFzZWQgb24gc29tZSB1bnVzdWFsIGNoaXBzZXQs
IGJ1dCBpdA0KLSAgdXN1YWxseSB3b3Jrcy4gSWYgYm90aCBQQ0kgQklPUyBh
bmQgZGlyZWN0IFBDSSBhY2Nlc3MgYXJlIGVuYWJsZWQsDQotICB0aGUgdXNl
IG9mIEJJT1MgaXMgcHJlZmVycmVkLiBJZiB1bnN1cmUsIHNheSBZLg0KK1BD
SSBhY2Nlc3Mgc3VwcG9ydA0KK0NPTkZJR19QQ0lfR09CSU9TDQorICBJZiB5
b3UgaGF2ZSBlbmFibGVkIFBDSSBidXMgc3VwcG9ydCBhYm92ZSwgTGludXgg
bmVlZHMgdG8gZGV0ZXJtaW5lDQorICB3aGF0IFBDSSBkZXZpY2VzIHlvdSBo
YXZlLCBhbmQgaG93IHRoZXkgYXJlIGNvbmZpZ3VyZWQuIFRoaXMgc2V0dGlu
Zw0KKyAgZGVhbHMgd2l0aCBob3cgTGludXggc2hvdWxkIGRvIHRoYXQuDQor
DQorICBXaXRoaW4gdGhlIGtlcm5lbCwgdHdvIHNlcGFyYXRlIG9wdGlvbnMg
YXJlIHVzZWQgdG8gZW5hYmxlIHRoZSB0d28NCisgIHBvc3NpYmxlIHdheXMg
TGludXggaGFzIGZvciBkZXRlcm1pbmluZyB0aGlzLiBUaGV5IGFyZSBhcyBm
b2xsb3dzOg0KKw0KKyAgQ09ORklHX1BDSV9CSU9TDQorICAgICAgVGhpcyBz
YXlzIHRvIGFsbG93IExpbnV4IHRvIHVzZSB5b3VyIFBDSSBCSU9TIHRvIGRl
dGVjdCB0aGUgUENJDQorICAgICAgZGV2aWNlcyBhbmQgZGV0ZXJtaW5lIHRo
ZWlyIGNvbmZpZ3VyYXRpb24uIE5vdGUgdGhhdCBzb21lIG9sZA0KKyAgICAg
IFBDSSBtb3RoZXJib2FyZHMgaGF2ZSBCSU9TIGJ1Z3MgYW5kIG1heSBjcmFz
aCBpZiB0aGlzIG1vZGUgaXMNCisgICAgICBzZWxlY3RlZC4NCisNCisgIENP
TkZJR19QQ0lfRElSRUNUDQorICAgICAgVGhpcyBzYXlzIHRoYXQgTGludXgg
c2hvdWxkIGVuYWJsZSBkaXJlY3QgaGFyZHdhcmUgc3VwcG9ydCBmb3INCisg
ICAgICBkZXRlY3RpbmcgUENJIGRldmljZXMgYW5kIGRldGVybWluaW5nIHRo
ZWlyIGNvbmZpZ3VyYXRpb24uIEl0DQorICAgICAgbWlnaHQgZmFpbCBpZiB5
b3VyIG1hY2hpbmUgaXMgYmFzZWQgb24gc29tZSB1bnVzdWFsIGNoaXBzZXQs
DQorICAgICAgYnV0IGl0IHVzdWFsbHkgd29ya3MuDQorDQorICBUaGlzIHNl
dHRpbmcgaXMgdXNlZCB0byBkZXRlcm1pbmUgdGhlIHZhbGlkIGNvbWJpbmF0
aW9ucyBvZiB0aGUNCisgIGFib3ZlIHR3byBvcHRpb25zLCBzaW5jZSBhdCBs
ZWFzdCBvbmUgb2YgdGhlbSBNVVNUIGJlIHNlbGVjdGVkLiBUaGUNCisgIGF2
YWlsYWJsZSBjaG9pY2VzIGFyZSBhcyBmb2xsb3dzOg0KKw0KKyAgQklPUyAg
ICBUaGlzIGVuYWJsZXMgdGhlIENPTkZJR19QQ0lfQklPUyBvcHRpb24gb25s
eS4NCisgIERpcmVjdCAgVGhpcyBlbmFibGVzIHRoZSBDT05GSUdfUENJX0RJ
UkVDVCBvcHRpb24gb25seS4NCisgIEFueSAgICAgVGhpcyBlbmFibGVzIGJv
dGggb3B0aW9ucy4NCisNCisgIElmIHlvdSBhcmUgdXNpbmcgTGludXggb24g
c29tZSBlbWJlZGRlZCBzeXN0ZW0gd2l0aCBubyBCSU9TLCBvcg0KKyAgTGlu
dXggc2F5cyBpdCBjYW5ub3QgdXNlIHlvdXIgQklPUywgeW91IHNob3VsZCBz
ZWxlY3QgRElSRUNUIGhlcmUsDQorICBvdGhlcndpc2UgeW91IHNob3VsZCBw
cm9iYWJseSBzZWxlY3QgQU5ZIGhlcmUuIFNlbGVjdCBCSU9TIG9ubHkgaWYN
CisgIHlvdSBoYXZlIGFuIHVudXN1YWwgY2hpcHNldCBmb3Igd2hpY2ggRElS
RUNUIGRvZXNuJ3Qgd29yay4NCiANCiBQQ0kgcXVpcmtzDQogQ09ORklHX1BD
SV9RVUlSS1MNCiAgIElmIHlvdSBoYXZlIGEgYnJva2VuIEJJT1MsIGl0IG1h
eSBmYWlsIHRvIHNldCB1cCB0aGUgUENJIGJ1cyBpbiBhDQogICBjb3JyZWN0
IG9yIG9wdGltYWwgZmFzaGlvbi4gU2F5aW5nIFkgaGVyZSB3aWxsIGNvcnJl
Y3QgdGhhdCBwcm9ibGVtLg0K
--1421910094-1228150175-914933099=:15221--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/