Re: CONFIG_PCI_BIOS in 2.1.132

Linus Torvalds (torvalds@transmeta.com)
23 Dec 1998 19:07:18 GMT


In article <Pine.LNX.3.96.981223182100.568B-100000@ps.cus.umist.ac.uk>,
Riley Williams <rhw@bigfoot.com> wrote:
>
>That should provide you with the correct combination of options...

It doesn't work too well, though - try it and see what happens to the
config file after doing "make oldconfig" etc.

The proper fix is probably something like

unset CONFIG_PCI_BIOS CONFIG_PCI_DIRECT
choice 'PCI access mode' \
"BIOS CONFIG_PCI_ACCESS_BIOS \
Direct CONFIG_PCI_ACCESS_DIRECT \
Both CONFIG_PCI_ACCESS_BOTH" CONFIG_PCI_ACCESS_BOTH
if [ "$CONFIG_PCI_ACCESS_BIOS" = "y" -o "$CONFIG_PCI_ACCESS_BOTH" = "y" ]
then
define_bool CONFIG_PCI_BIOS y
fi
if [ "$CONFIG_PCI_ACCESS_DIRECT" = y -o "$CONFIG_PCI_ACCESS_BOTH" = "y" ]
then
define_bool CONFIG_PCI_DIRECT y
fi

(note the "unset" and the different name spaces to make sure that we
don't get configuration confusion).

I have _not_ tested the above, but I tested your previous patch and it
didn't work reliably. The above approach _should_ work, but if anybody
really wants to see this in the next kernel, please test it out and send
me a patch if/when it works..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/