Re: idle_task priority and scheduling 2.1.131

Rik van Riel (H.H.vanRiel@phys.uu.nl)
Thu, 3 Dec 1998 21:57:44 +0100 (CET)

On Thu, 3 Dec 1998, Andrea Arcangeli wrote:
> On Thu, 3 Dec 1998, Rik van Riel wrote:
>
> >Take a look at the != SCHED_OTHER clause in reschedule_idle.
>
> Hug yes, it' s that my current reschedule_idle, goodness() is clobbering
> SCHED_YIELD before I have chance to see it. So the stock kernel should be
> fine. Thanks.
>
> if (goodness(p, this, this->processor) >
> goodness(this, this, this->processor) + 3 ||
> p->policy != SCHED_OTHER)
> current->need_resched = 1;

Move the != SCHED_OTHER test before the goodness test,
it will avoid clobbering p->policy, fouling up the
actual reschedule.

regards,

Rik -- the flu hits, the flu hits, the flu hits -- MORE
+-------------------------------------------------------------------+
| Linux memory management tour guide. H.H.vanRiel@phys.uu.nl |
| Scouting Vries cubscout leader. http://www.phys.uu.nl/~riel/ |
+-------------------------------------------------------------------+

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/