Re: patch to drivers/net/8390.c

Alan Cox (alan@lxorguk.ukuu.org.uk)
Tue, 1 Dec 1998 16:43:57 +0000 (GMT)

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Tony Lill: "Bug in ICMP handling in ip_masq.c (with patch)"
Previous message: Gregory Maxwell: "RE: Problems with to large of a kernel"

> Ok, I see that now. 8390.h conditionally defines a macro EI_SHIFT to
> use ei_local as an implicit parameter if one of a small set of specific
> config options is set. (Really nice coding style, not.)
> Would it be acceptable to make the declaration of ei_local (in this
> case) conditional on whether it's actually used? Something like:

Yuck. That makes it even less obvious.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

Next message: Tony Lill: "Bug in ICMP handling in ip_masq.c (with patch)"
Previous message: Gregory Maxwell: "RE: Problems with to large of a kernel"