This works around obscure bug both in linux tty. Bug is present in
BOTH 2.0.3X and 2.1.129. It can be reproduced by holding ^D on login
prompt on some machines (my 386, someones 486sx, someone reproduced
that on k6). Please apply.
The patch looks good, but I'm not sure I'd call this a bug a in tty_io.c
(and so I'd nuke the comments you added to tty_io.c and keyboard.c).
Only the console/keyboard driver directly accesses driver->table at
interrupt time, regardless of whether or not the device has been opened
by the high-level tty layer calling driver.open.
So I'd call the bug as being in the console driver, not the tty layer.
It's simply not a good thing for the device driver to muck with a port
before it's been given permission to do so via the open call. As far as
I know, only the console driver short-circuits this particular
abstraction barrier, and the reason why it does so more of an historical
accident.
- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/