typo in scsi_obsolete.c

Andrea Arcangeli (andrea@e-mind.com)
Sun, 29 Nov 1998 17:20:04 +0100 (CET)

Reviewing my last patches that gone in the kernel, I noticed a bug I
introduced by mistake :-(. Excuse me. This is the patch against 2.1.130
that fix the bug:

Index: linux/drivers/scsi/scsi_obsolete.c
diff -u linux/drivers/scsi/scsi_obsolete.c:1.1.1.1 linux/drivers/scsi/scsi_obsolete.c:1.1.1.1.2.1
--- linux/drivers/scsi/scsi_obsolete.c:1.1.1.1 Fri Nov 20 00:02:54 1998
+++ linux/drivers/scsi/scsi_obsolete.c Sun Nov 29 17:13:41 1998
@@ -607,10 +607,9 @@
if ((++SCpnt->retries) < SCpnt->allowed)
{
if ((SCpnt->retries >= (SCpnt->allowed >> 1))
- /* FIXME: last_reset == 0 is allowed
- * && !(SCpnt->host->last_reset > 0 */ &&
- time_before(jiffies, SCpnt->host->last_reset
- + MIN_RESET_PERIOD)
+ /* FIXME: last_reset == 0 is allowed */
+ && time_after(jiffies, SCpnt->host->last_reset
+ + MIN_RESET_PERIOD)
&& !(SCpnt->flags & WAS_RESET))
{
printk("scsi%d channel %d : resetting for second half of retries.\n",

Right now I am browsing the scsi code waiting for understanding which is
the best way to handle the dev_last_reset[] (aic7xxx) and ->last_reset
cases...

Andrea Arcangeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/