Re: Dynamic IP hack

Alexey Kuznetsov (kuznet@ms2.inr.ac.ru)
Sat, 17 Oct 1998 23:40:18 +0400 (MSK DST)


Hello!

> And as usual I forgot to append it. But now I did.
.....
> + struct device *dev;
> +
> + int want_rewrite = sysctl_ip_dynaddr & 4 || (sysctl_ip_dynaddr & 3 && sk->state == TCP_SYN_SENT);

Did you read my comment there?

Such kind of tricks become dangerous,
when they overstep some reasonable limit.

Could you move all this under some CONFIG_* option?
Also, seems, this patch does not guarantee, that socket in established
state is not mangled. Not good.

Alexey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/