Re: isdn performance problem in 2.1[19]-[22]

Henner Eisen (eis@baty.hanse.de)
Fri, 9 Oct 1998 00:11:25 +0200


>>>>> " " == David Woodhouse <David.Woodhouse@mvhi.com> writes:
> This patch, unfortunately, doesn't help. Our proxy machine,
> running 2.1.123, started showing precisely the same behaviour
> that I reported some time ago - (

I now detected another potential problem that might only be triggered
when using ippp and the HL driver calls the isdn BSENT statcallb() from
interrupt handler. (This might also give different results with different
isdn HL drivers). Does the following patch help? (patch is editded by hand
and will have different ofsets when applied to standard kernel. Let me know
if patching fails against standard kernel)

Henner

--- 2.1.124-i4ldev/drivers/isdn/isdn_net.c Mon Sep 7 23:23:03 1998
+++ 2.1.124-ix25/drivers/isdn/isdn_net.c Thu Oct 8 23:41:25 1998
@@ -618,8 +624,12 @@
lp->sav_skb = NULL;
mark_bh(NET_BH);
} else {
- return 1;
+/* We might have been called from an HL driver's interrupt handler that
+will mark the channel ready before returning from interrupt. Better
+mark the device ready right now in order to prevent potential stalls.
+This is just a preliminary (diagnostic) hack.
+*/
}
}
- if (test_and_clear_bit(0, (void *) &(p->dev.tbusy)))
+ clear_bit(0, (void *) &(p->dev.tbusy));
mark_bh(NET_BH);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/