Re: [BUGFIX] [FIXME!] 2.1.107-2.1.124 cpu_to_le32(0) fix at Sparc

Andreas Schwab (schwab@issan.informatik.uni-dortmund.de)
07 Oct 1998 10:58:09 +0200

"Alexandr D. Kanevskiy" <kad@dgtu.donetsk.ua> writes:

|> I just upgrade my Sun Sparcstation IPC to 2.1.124 and
|> found this thing. This couses a compile error.
|>
|>
|> --- fs/ext2/truncate.c.org Tue Oct 6 15:54:22 1998
|> +++ fs/ext2/truncate.c Tue Oct 6 15:55:19 1998
|> @@ -62,7 +62,8 @@
|> #define TINDIRECT_BLOCK(inode,offset) \
|> (INDIRECT_BLOCK(inode,offset) / (addr_per_block*addr_per_block))
|>
|> -static u32 le32_zero = cpu_to_le32(0);
|> +/* static u32 le32_zero = cpu_to_le32(0); */
|> +static u32 le32_zero = 0; /* FIXME ! */
|>
|> /*
|> * Truncate has the most races in the whole filesystem: coding it is

The correct fix is to erase le32_zero completely from the sources and not
let it come back again. Just globally replace it by a plain zero.

-- 
Andreas Schwab                                      "And now for something
schwab@issan.cs.uni-dortmund.de                      completely different"
schwab@gnu.org


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/