Re: [patch] Re: [PATCH] modules_install

Nick Holloway (Nick.Holloway@alfie.demon.co.uk)
5 Oct 1998 22:31:45 +0100

alan@lxorguk.ukuu.org.uk (Alan Cox) writes:
> Just back the patch out. Its a complete turkey. If you want to fix it
> you need additional tools like mktemp which not all distributions include

There is no need to use /tmp, which would require mktemp. Just use
$MODLIB to hold the temporary files -- a) we know it is writeable, and
b) it shouldn't be writeable by J. Random.

The final section of the Makefile to install the modules becomes:

ls *.o > $$MODLIB/.allmods; \
echo $$MODULES | tr ' ' '\n' | sort | \
comm -23 $$MODLIB/.allmods - > $$MODLIB/.misc; \
if [ -s .misc ]; then inst_mod $$MODLIB/.misc misc; fi; \
rm -f $$MODLIB/.misc $$MODLIB/.allmods; \

Sorry, no patch, as I don't yet have 2.1.124 to generate a patch against.

-- 
 `O O'  | Home: Nick.Holloway@alfie.demon.co.uk  http://www.alfie.demon.co.uk/
// ^ \\ | Work: Nick.Holloway@parallax.co.uk


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/