Re: [PATCH] modules_install

Gerhard Mack (gmack@imag.net)
Sun, 4 Oct 1998 14:21:25 -0700 (PDT)


On Sun, 4 Oct 1998, Alan Cox wrote:

> > `make modules_install' creates some temporary files inside the kernel source
> > directory. However, if that directory is imported using NFS in the recommended
> > and secure way, root is not allowed to create files there. This patch solves
> > that problem by creating the temporary files in /tmp.
>
> This is dangerous and broken. Folk spent a while stamping all the misuses of
> /tmp out of the kernel build tree a while ago. Dont introduce new ones. If
> you want root writable areas use the right mount options
>
> > + if [ -s /tmp/.misc.$$$$ ]; then inst_mod /tmp/.misc.$$$$ misc; fi; \
> > + rm -f /tmp/.misc.$$$$ /tmp/.allmods.$$$$; \
>
> Linus, please dont apply this "fix"

What's wrong with /root/tmp/ ?

--
Gerhard Mack
irc-admin skyline.starchat.net
	
gmack@imag.net
InnerFIRE@starchat.net

As a computer I find your faith in technology amusing.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/