I got an oops why trying to
mount /dev/cdrom /cdrom -o iocharset
Thisn't a correct usage of the iocharset option, but it shouldn't generate
an ops either. I thought it was quite confusing to do '*value++ = 0'. I
can't see why this shouldn't be replaced by a simple 'value++' since the
'=' 'value' points to will never be used anyway.
--- fs/isofs/inode.c-orig Thu Sep 10 15:36:55 1998
+++ fs/isofs/inode.c Thu Sep 10 16:40:57 1998
@@ -341,10 +341,10 @@
continue;
}
if ((value = strchr(this_char,'=')) != NULL)
- *value++ = 0;
+ value++;
#ifdef CONFIG_JOLIET
- if (!strcmp(this_char,"iocharset")) {
+ if (!strcmp(this_char,"iocharset") && value) {
popt->iocharset = value;
while (*value && *value != ',')
value++;
(patch applies on 2.1.120)
- Ulf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/faq.html