Re: 2.1.120pre3 still has sound mem leak

Garst R. Reese (reese@isn.net)
Wed, 02 Sep 1998 15:25:23 -0300

This is a multi-part message in MIME format.
--------------040A832B88416AECFAA9410C
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Michael L. Galbraith wrote:
>
> On Tue, 1 Sep 1998, Garst R. Reese wrote:
>
> > Each use of sound followed by as many rmmod -a's as you choose,
> > decreases total mem by 64K. This is with an old LT SB compatible ESS488
> > 8 bit mono sound.
> > On the first attempt, rmmod -a resulted in the msg.
> > "sound module went missing!"
> > This mem leak happened way back when, but I thought it had gone away. I
> > don't let Biff bark very often :)
> > --
> > Garst
>
> Hi,
>
> Are you using the SB driver? According to memleak, it has a leak at
> sb_mixer.c:456, but that's only 92 bytes. I've been using it to test
> memleak with, but the results seem strange. Can anyone explain the
> buffer/slab growth in the following? Is this normal?
>
> -Mike
>
> Script started on Wed Sep 2 15:45:57 1998
Yes, I am using the SB driver.
Oleg Drokin sent me the attached diff that fixes my problem. He also
sent it to alan some time ago,but apparently it never got applied.
I'll check the memleak also. Thanks

-- 
Garst
--------------040A832B88416AECFAA9410C
Content-Type: text/plain; charset=us-ascii;
 name="sound-2.1.117.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="sound-2.1.117.diff"


diff -ur /ksi/usr/src/linux-2.1.117/drivers/sound/README.FIRST /usr/src/linux/drivers/sound/README.FIRST
--- /ksi/usr/src/linux-2.1.117/drivers/sound/README.FIRST	Tue Aug 18 12:32:11 1998
+++ /usr/src/linux/drivers/sound/README.FIRST	Sat Aug 22 19:50:15 1998
@@ -1,4 +1,4 @@
-The modular sound driver patches where funded by Red Hat Software 
+The modular sound driver patches were funded by Red Hat Software 
 (www.redhat.com). The sound driver here is thus a modified version of 
 Hannu's code. Please bear that in mind when considering the appropriate
 forums for bug reporting. 
diff -ur /ksi/usr/src/linux-2.1.117/drivers/sound/dmabuf.c /usr/src/linux/drivers/sound/dmabuf.c
--- /ksi/usr/src/linux-2.1.117/drivers/sound/dmabuf.c	Tue Aug 18 12:50:48 1998
+++ /usr/src/linux/drivers/sound/dmabuf.c	Sat Aug 22 19:40:16 1998
@@ -206,6 +206,7 @@
 		dmap->dma_mode = DMODE_NONE;
 	dmap->flags &= ~DMA_BUSY;
 	disable_dma(dmap->dma);
+	sound_free_dmap(dmap);
 }
 
 


--------------040A832B88416AECFAA9410C--




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html