Re: 2.1.118 Tons of oopes

Rogier Wolff (R.E.Wolff@BitWizard.nl)
Wed, 2 Sep 1998 10:00:11 +0200 (MEST)

Linus Torvalds wrote:
> Personally, I would suggest against changing all the file and inode
> operations unless somebody can show cases where it makes a real-world
> difference in performance..

Linus, if someone does go ahead and does this, I would suggest some
preprocessor trickery to allow us to compile a kernel with the
classical tests and without.

#ifdef DEBUGGING
#define SUPERFLUOUS_CHECK(x) if (x)
#else
#define SUPERFLUOUS_CHECK(x) if (0)
#endif

SUPERFLUOUS_CHECK (dentry != NULL) {
return -EBADF;
}

Personally I rather prefer having the checks performed instead of say
a 10% performance drop.

Roger.

-- 
| The secret of success is sincerity.  Once you can |  R.E.Wolff@BitWizard.nl 
| fake that, you've got it made.  -- Jean Giraudoux |       T: +31-15-2137555 
-We write Linux device drivers for any device you may have! Call for a quote-


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html