Re: linux/Makefile: CONFIG_SHELL and SHELL

Clifford Wolf (clifford@clifford.at)
Wed, 2 Sep 1998 07:16:53 +0200 (MEST)


On Tue, 1 Sep 1998, Linus Torvalds wrote:

> On Wed, 2 Sep 1998, Clifford Wolf wrote:
> >
> > I attached a patch which fixes the broken Makefiles. I don't know if we
> > use bash features - makeing the suggestion that /bin/sh is bash -
> > somewhere else in the kernel too.
>
> Why not fix "make" instead to either handle the shell extensions or at
> least notice that it doesn't know about some new meta-characters. As far
> as I know (but yes, I'm too lazy to try to find the standard), the brace
> expansion is part of the POSIX shell standard, and if make can't handle it
> then make is very arguably broken.

hmmm .. as far as I see make knows this meta characters and just starts
/bin/sh if they appare. But at least my /bin/sh which should be POSIX
sompliant (but I really can't guarantee for that and don't have the
standard handy too) does not know about the brace expansion. But bash
knows about it - and as long as /bin/sh is bash noone will recognise that
there is a problem. The variable CONFIG_SHELL is there for the case that
one needs (non-standard?) bash features - and IMHO it seams like we need
them in this case.

- clifford

-- -- -- -- -- -- -- -- -- -- -- -- --
Clifford Wolf
magnet - Internet at Work IRC: efnet / clifford
Director of System Development http://www.clifford.at/
e-mail: c.wolf@magnet.at email: god@clifford.at

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html