Re: is this fs corruption?

Matthias Urlichs (smurf@noris.de)
1 Sep 1998 22:18:41 +0200


"Stephen C. Tweedie" <sct@redhat.com> writes:
>
> <arcangeli@mbox.queen.it> said:
> > Block bitmap differences: -58421 -58422 -58423 -58424 -58425 -58426
> > -58427 -58428 -58429 -58430 -58431 -58432 -58440 -58441 -58442 -58443
> > -58444
> > Free blocks count wrong for group #7 (358, counted=375).
>
> This e2fsck output indicates that thhe filesystem has been dismounted
> with open files still outstanding.

Would it be possible to reduce this message to one (or zero) characters?

If you're rebooting a Netnews server, for instance, the readers are likely
to have an old history file or two open. Instant 200-MByte deleted file,
which translates to 200000 blocks, or more than half an hour of additional
downtime if you happen to print the stuff on a 9600 baud serial console. :-/
(And no, I don't like the -p option because getting the machine up at all,
even if it's limping along with a few broken files, is better FOR ME than
to have it halted in single-user mode for a whole weekend. YMMV of course.)

This change should probably depend on verbosity level or whatever, but
(since I never need those block numbers anyway) I just commented them out.

Index: e2fsck/pass5.c
--- e2fsck/pass5.c.orig Fri, 26 Dec 1997 07:41:11 +0100 smurf (kernel_e2fs/c/40_pass5.c 1.2 664) base.8
+++ e2fsck/pass5.c Fri, 26 Dec 1997 07:46:57 +0100 smurf (kernel_e2fs/c/40_pass5.c 1.3 664) noris.2
@@ -112,8 +112,10 @@
/*
* Block not used, but marked in use in the bitmap.
*/
- if (!preen)
- printf(" -%u", i);
+ if (!preen) {
+ /* printf(" -%u", i); */
+ printf("-");
+ }
if (do_fix)
ext2fs_unmark_block_bitmap(fs->block_map,
i);
@@ -121,8 +123,10 @@
/*
* Block used, but not marked in use in the bitmap.
*/
- if (!preen)
- printf(" +%u", i);
+ if (!preen) {
+ /* printf(" +%u", i); */
+ printf("+");
+ }
if (do_fix)
ext2fs_mark_block_bitmap(fs->block_map,
i);

-- 
Matthias Urlichs      |        noris network GmbH      |       smurf@noris.de
The quote was selected randomly. Really.    |      http://www.noris.de/~smurf/
-- 
Electricians do it in their shorts.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html