Re: 2.1.118 Tons of oopes

Richard Gooch (rgooch@atnf.csiro.au)
Sat, 29 Aug 1998 11:26:42 +1000


greerga@nidhogg.ham.muohio.edu writes:
> On Fri, 28 Aug 1998, Richard Gooch wrote:
>
> >What I don't understand is *why* this flush() method is termed
> >mandatory (hence the intentional source breakage), and yet in *every*
> >driver in the 2.1.118 patch it is set to NULL.
>
> If you go poking in include/linux/fs.h, you notice this structure:
>
[...]
> >So what is the difference between breaking all source and then inserting
> >NULLs, or appending the new method and taking advantage of automatic
> >structure initialisation. The only difference I've seen is that one
> >approach breaks things and requires lots of effort.
>
> See above, it fixes a very nasty bug in a way that others can also take
> advantage of. Now, if any other network filesystem, such as Coda, needs a
> special flush() method, they just add it to the structure. Anyone else who
> doesn't need it can just stuff a NULL in there and be done with it. Or
> perhaps Reiserfs would like one which isn't in the kernel. It's there for
> the "hey, look at me" factor. Then after you notice it, you put a NULL in
> if you don't care.

I'm not interested in what the flush() method fixes. I'm not arguing
that. I'm saying that if Linus wanted to make people aware of the new
flush() method, he could simply have announced it to the kernel list
instead of breaking all drivers.

> >Again, if there is some other hidden assumption going on here, I'd like to
> >know. But *nobody* has explained how the breakage has helped anything.
>
> See above.

I'll rephrase my question: why is it better to break every driver than
to announce a new flush() method which has been appended?

[...]
> >Maybe the inner circle *does* know some deep dark secret, but *I*
> >don't know it and it hasn't been made public. In light of this, my
> >questions are entirely reasonable. Instead of flaming me for pursuing
> >this, why not come forth with some clearer explanations?
>
> Well, I can count the number of kernel things I've done on one hand and I
> just kind of read the source. :)

You're still not answering my key point: why break all drivers rather
than post an announcement that a new flush() method exists?

Regards,

Richard....

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html