Re: patch: IP autoconfig over FDDI

Martin Mares (mj@ucw.cz)
Thu, 27 Aug 1998 23:21:34 +0200

> Now my particular problem is that FDDI is a perfectly good device to
> autoconfig. Further, why not allow autoconfig on any device? If you have
> a device up why not allow ARP/BOOTP over it?
>
> This code has remain unchanged (although it has moved from
> fs/nfs/nfsroot.c) since at least 2.0.
>
> The following patch to net/ipv4/ipconfig.c (2.1.118) removes the check:
>
>
> --- ipconfig.c 1998/08/26 18:52:01 1.1
> +++ ipconfig.c 1998/08/26 18:52:41
> @@ -103,8 +103,7 @@
>
> last = &ic_first_dev;
> for (dev = dev_base; dev; dev = dev->next)
> - if (dev->type < ARPHRD_SLIP &&
> - !(dev->flags & (IFF_LOOPBACK | IFF_POINTOPOINT)) &&
> + if (!(dev->flags & (IFF_LOOPBACK | IFF_POINTOPOINT)) &&
> strncmp(dev->name, "dummy", 5) &&
> (!user_dev_name[0] || !strcmp(dev->name, user_dev_name))) {
> oflags = dev->flags;
>

I'm not sure this is the right way to as it won't filter out devices which are
unable to run without userland initializing them. It would be probably better
to list all supported ARPHRD types in ipconfig.c.

Have a nice fortnight

-- 
Martin `MJ' Mares   <mj@ucw.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"IBM = International Band of Magicians"


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html