Re: Linux 2.1.118 SMP problem

Linus Torvalds (torvalds@transmeta.com)
Wed, 26 Aug 1998 15:03:41 -0700 (PDT)


On Wed, 26 Aug 1998, Alan Cox wrote:
>
> Also that bug has been there for a lot longer than the past 2 or 3 kernels

This is btw not necessarily true..

del_timer() doing a synchronize_bh() is actually a fairly new thing: it's
definitely the "right thing" TM to do (the comment says exactly why: we
shouldn't return from del_timer until we've made sure that the timer has
really gone away), but it may not be the right place to do this all.

I'm inclined to remove the line completely. It wasn't added to fix any
known bugs, I added it because I think it is the right thing to do, but I
may well have been wrong about that.

I'll think about it, but Steffen, could you test the kernel with just that
line deleted?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html