Re: patch-2.1.117 adds bad ide_xlate_1024()

Mark Lord (mlord@pobox.com)
Mon, 24 Aug 1998 15:37:10 +0000


Andries.Brouwer@cwi.nl wrote:
...
> > a very bad idea.
> > It decides that all disks should use a translated geometry. Why?

I dunno.. probably Microsoft decided it a long time ago.

We debated this update a few months ago on the kernel list,
and there were no objections then, from you or anyone else.

But.. the patch is still incorrect, I suppose.

The intent was to respect any existing geometry found in the partition
table,
and default to LBA translation for drives which did not already have at
least one valid entry in the table.

The motivation is simple: I get tons of emails complaining that
whenever a new disk is installed, Linux defaults to the "wrong"
translation.

But.. the patch is still incorrect, I suppose.

Andries: we really could use some of your non-flaming expertise here..
how about fixing that for-loop in genhd.c to skip the new LBA
translation
if any valid partitions are found on the drive. That is what I wanted
it to do, and what everybody agreed to, but I just don't recall offhand
how to test for an empty or uninitialized partition table.

Fix it for us. Thanks.

-- 
mlord@pobox.com

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html