Thanks for taking care of the CDROM interface again. One comment:
- cdi->options = CDO_AUTO_CLOSE | CDO_USE_FFLAGS | CDO_LOCK;
- /* default compatibility mode */
+ cdi->options = CDO_AUTO_CLOSE | CDO_USE_FFLAGS | CDO_CHECK_TYPE | CDO_LOCK;
+ if (dont_check_media_type==0)
+ cdi->options |= (int) CDO_CHECK_TYPE;
This breaks 2.0 compatibility and will couse people to randomly send
patches to comment out some of the code in cdrom.c, because their
favorite cdrom player program doesn't work anymore. This has happened
before! Moreover, the code is wrong. "==" -> "!=" and "|=" ->
"&= ~". Or something. Just remove the "| CDO_CHECK_TYPE" in the
first line. Please.
---david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu