bug in lxdialog (and the bugfix)

Clifford Wolf (clifford@clifford.at)
Sat, 13 Jun 1998 18:35:43 +0200 (MEST)


This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

---1430038202-964172506-897755743=:15519
Content-Type: TEXT/PLAIN; charset=US-ASCII

Hi,

I had allready problems with the Page-Down key in menuconfig in the first
2.0.x versions - but till now I had never the time to have a look at it.
The symptom was that I got a broken menu if I pressed the Page-Down key in
a configuration menu. I attached a little patch that fixes this bug.

The reason was that lxdialog outputs the lines at the bottom of the
window while scrolling is turned on - so ncurses ouputs an extra newline.
The patch moves the calls to scrollok() to other locations so that
scrolling is now disabled when the item is printed out.

BTW: The calls to scrollok() are *not* necessary at all! They are only
needed for the automatic scrolling - Scrolling by calling the functions
scroll() and wscrl() work without them to. So if I'm not compleatly
wrong we could remove most of the calles to the scrollok() function.

I don't have the source of the original dialog program by Savio Lam.
So I can't figure out if this bug exist in the original version too
or only in the hacked one. William: I guess that you have the original
source - could you have a look at it and forward this mail to Savio if
needed?

- clifford

PS: The attached patch is for 2.1.105 - but i don't think that they are
any changes to this file made at all ...

-- -- -- -- -- -- -- -- -- -- -- -- --
Clifford Wolf
magnet - Internet at Work IRC: efnet / clifford
Director of System Development http://www.clifford.at/
e-mail: c.wolf@magnet.at email: god@clifford.at

---1430038202-964172506-897755743=:15519
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="menubox.c.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.980613183543.15519B@babylon.clifford.at>
Content-Description: menubox.c.diff

LS0tIGxpbnV4L3NjcmlwdHMvbHhkaWFsb2cvbWVudWJveC5jLm9yaWcJU2F0
IEp1biAxMyAxNjo0MTo0OSAxOTk4DQorKysgbGludXgvc2NyaXB0cy9seGRp
YWxvZy9tZW51Ym94LmMJU2F0IEp1biAxMyAxNzoyMzoyNyAxOTk4DQpAQCAt
MjcyLDE1ICsyNzIsMTUgQEANCiAgICAgICAgICAgICAgICAgY2hvaWNlID0g
MDsNCiANCiAgICAgICAgICAgICB9IGVsc2UgaWYgKGtleSA9PSBLRVlfTlBB
R0UpIHsNCi0JICAgICAgICBzY3JvbGxvayAobWVudSwgVFJVRSk7DQogICAg
ICAgICAgICAgICAgIGZvciAoaT0wOyAoaSA8IG1heF9jaG9pY2UpICYmIChz
Y3JvbGwrbWF4X2Nob2ljZSA8IGl0ZW1fbm8pOyBpKyspIHsNCisJCSAgICBz
Y3JvbGxvayAobWVudSwgVFJVRSk7DQogCQkgICAgc2Nyb2xsKG1lbnUpOw0K
KwkJICAgIHNjcm9sbG9rIChtZW51LCBGQUxTRSk7DQogICAgICAgICAgICAg
ICAgICAgICBzY3JvbGwrKzsNCiAgICAgICAgICAgICAgICAgICAgIHByaW50
X2l0ZW0gKG1lbnUsIGl0ZW1zWyhzY3JvbGwrbWF4X2Nob2ljZS0xKSoyKzFd
LA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4X2Nob2lj
ZS0xLCBGQUxTRSwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IChpdGVtc1soc2Nyb2xsK21heF9jaG9pY2UtMSkqMl1bMF0gIT0gJzonKSk7
DQogICAgICAgICAgICAgICAgIH0NCi0gICAgICAgICAgICAgICAgc2Nyb2xs
b2sgKG1lbnUsIEZBTFNFKTsNCiAgICAgICAgICAgICAgICAgY2hvaWNlID0g
MDsNCiANCiAgICAgICAgICAgICB9IGVsc2UNCg==
---1430038202-964172506-897755743=:15519--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu