Re: Some ham radio linux-2.1.105 fixes

Thomas Sailer (sailer@ife.ee.ethz.ch)
Mon, 08 Jun 1998 11:13:51 +0200


Lord of the Files wrote:
>
> The new baycom_epp module in linux-2.1.105 references some symbols that
> do not appear to be definied anywhere in the kernel:
>
> parport_epp_write
> parport_epp_read
> parport_epp_write_addr
> parport_epp_read_addr
> parport_epp_check_timeout

This is due to a pending parport patch, obviously not yet
integrated. NB: The patch has been posted to linux-kernel
some time ago (with overwhelming feedback 8-)) and is also
on Andrew Tridgell's Jitterbug Page...

> I guess that parport_epp_{read,write} should be parport_{read,write},
> but there do not appear to be corresponding routines for
> parport_epp_{write_addr,read_addr,check_timeout}.

No, your guess is wrong.

> o hweight{8,16,32} symbols are referenced by some of
> the sound modem code, so they should not be commented
> out.

Since there are several modules that need the "hamming weight" (aka
population
count) functionality and several CPU archs have instructions for this
that are faster than the generic C code, my idea was to move these
routines
to arch specific code. This is also in a pending patch, obviously not
yet
integrated.

What I want from Linus is a statement whether the moving of these
routines
to asm/bitops.h (or wherever) is ok or not.

Tom

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu