Re: New pre-patch (Re: [PATCH] kswapd fully sysctl tunable)

David S. Miller (
Sun, 3 May 1998 06:26:37 -0700

Date: Sun, 3 May 1998 14:35:31 +0200 (CEST)
From: Niels Kristian Bech Jensen <>

> This kernel release needs a minor bug fix for pppd to run properly with
> the new routing code. When your pppd doesn't work apply the following
> patch to pppd-2.2.0f or update to the newest pppd version.

That's not the problem. I have the same problem with pppd-2.3.3, which
worked perfectly with 2.1.99.

There was not one single change in pre-100 which could possibly cause
PPP to stop working. The only change in there that even has an
influence on PPP is the following:

diff -u --recursive --new-file v2.1.99/linux/net/ethernet/pe2.c linux/net/ethernet/pe2.c
--- v2.1.99/linux/net/ethernet/pe2.c Sun Mar 24 22:58:24 1996
+++ linux/net/ethernet/pe2.c Sat May 2 14:22:29 1998
@@ -11,7 +11,8 @@
struct device *dev = skb->dev;

skb->protocol = htons (ETH_P_IPX);
- dev->hard_header(skb, dev, ETH_P_IPX, dest_node, NULL, skb->len);
+ if(dev->hard_header)
+ dev->hard_header(skb, dev, ETH_P_IPX, dest_node, NULL, skb->len);

struct datalink_proto *

And this fixes a NULL pointer deref when doing IPX over PPP, which has
nothing to do with what you are attempting.

Are you absolutely sure you haven't changed one thing in your
configuration between 2.1.99 and pre-100?

I did some research and checked out the ppp-2.3.[34] release.
The error code you are seeing being printed out is the signature error
that a pppd will get without the fix mentioned in ppp.txt So I went
and checked if the fix is in the latest ppp-2.3.4, it is not. ;-(

The problem is that PPPD wants to setup a default route over an
interface which is not up, ppp-2.3.4 still does this and returns an
error. Look in ppp-2.3.*/pppd/sys-linux.c:sifdefaultroute(), change
it to return 1 even if ioctl() returns an error.

Does PPP now work for you with that change?

In any event it looks as if the ppp.txt file needs updating... ;-)

David S. Miller

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to