2.1.92: linux/net/core/profile.c wrong?

Horst von Brand (vonbrand@sleipnir.valparaiso.cl)
Mon, 06 Apr 1998 00:30:52 -0400

My new ifconfig (net-tools-1.44) complains about an unknown network devive
whiteh. Looking at /proc/net/dev, there is a line for that in there. Sure
enough, when my kernel boots it says something about deferring
initialization of whitehole.

OK, a grep over the sources lead me to the file mentioned. I gather this
has something to do with net profiling, but a special device? Looking over
the code, there are critical sections delimited by cli() ... sti().
Shouldn't that always be save_flags(); cli() ... restore_flags()? Also, in
some of the critical sections there are "atomic_inc(&net_profile_active)"
and "atomic_dec(&net_profile_active)". As I understand, this makes no
sense: If interrupts are turned off, there is no point to using atomic
operations.

Besides, this whitehole thing has got fixed IP addresses, AFAIKS from
whitehole_init():

whitehole_iph.saddr = in_aton("193.233.7.21");
whitehole_iph.daddr = in_aton("193.233.7.10");

Broken implementation of a good idea that needs to be cleaned up?

-- 
Horst von Brand                             vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Viņa del Mar, Chile                               +56 32 672616




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu