Re: fixes to arch/i386/boot/bootsect.S

Emmanuel Marty (core@mirus.fr)
Sun, 05 Apr 1998 23:10:39 +0200


Hello Michael,

>I am not sure it is very helpfull since actually there is no code in the
>Setup that checks for an processor <386.

Yes.. That's why I said "yet". I'd be willing to add that to setup.S,
it will only take a few bytes. Just a security check. I know it
sounds like hairsplitting... But IMHO it gives a better impression
than simply freezing.

>Note the last one above sets DS back to INITSEG.
>And thus the followed movb is ok. Seems you moved the 'pop ds' somewhere
>else, lost track about this change and thus created the bug.

My bad, you are right :) But that's not what confused me. I rather missed
the mov ds,ax above, so in my mind DS sticked to bootseg - you see
why I was worried. Thanks for clearing that up.

Anyway this makes the bootsector a bit smaller by a few bytes, in case we
need them sometime :), and gives setup a chance to be loaded on < 386
machines so that it can inform the user that the hardware is not
supported, instead of simply hanging - again I'm willing to add the
couple of lines to setup.S to do that :)

Emmanuel.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu