Re: patch for 2.1.90 net/core/iovec et al

David S. Miller (davem@dm.cobaltmicro.com)
Tue, 24 Mar 1998 09:43:58 -0800

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Jason Venner: "NFS & 2.0.32 8k reads/writes made a difference."
Previous message: Alexander V. Lukyanov: "aha2940UW + cdrom on alpha trouble"
Maybe in reply to: Bill Hawes: "patch for 2.1.90 net/core/iovec et al"
Next in thread: Linus Torvalds: "Re: patch for 2.1.90 net/core/iovec et al"
Reply: Linus Torvalds: "Re: patch for 2.1.90 net/core/iovec et al"

Bill, memcpy_toiovec() must return the amount data not copied
successfully when a fault occurs. The reason is that tcp_do_recvmsg()
in tcp.c must be able to move the "read sequence" byte count back
should memcpy_toiovec() fail mid-stream. Browse the call to
memcpy_toiovec() in there for details.

So please change this back in your patches.

Later,
David S. Miller
davem@dm.cobaltmicro.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

Next message: Jason Venner: "NFS & 2.0.32 8k reads/writes made a difference."
Previous message: Alexander V. Lukyanov: "aha2940UW + cdrom on alpha trouble"
Maybe in reply to: Bill Hawes: "patch for 2.1.90 net/core/iovec et al"
Next in thread: Linus Torvalds: "Re: patch for 2.1.90 net/core/iovec et al"
Reply: Linus Torvalds: "Re: patch for 2.1.90 net/core/iovec et al"