Re: patch 2.1.88 - cosmetic

Joel Scotkin (jscotkin@randomwalk.com)
Sun, 22 Feb 1998 15:27:36 -0500 (EST)


Hi folks!

Linus wrote:

>The "2" isn't O_RDWR - rather the reverse. It's _only_ write. The flags go
>tha sane way:
> 0 = 00 - no permissions
> 1 = 01 - read permissions
> 2 = 10 - write permissions
> 3 = 11 - read and write permissions
>
>while the O_RDONLY/O_RDWR things go the wrong way
>
> 0 - read, 1 - write, 2 - read-write
>
>due to (stupid, but understandable) historical UNIX issues. The other
>O_xxx flags are the same way, because they make sense even historically.

which doesn't give me a whole lot of confidence in this line in dquot.c
(line 970, 2.1.87):

dentry = open_namei(tmp, O_RDWR, 0600);

Thanks!
Joel

joel@randomwalk.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu