PC Speaker driver in 2.1.88

David Woodhouse (Dave@imladris.demon.co.uk)
Sat, 21 Feb 1998 16:29:16 +0000

I just had my first crash due to the PC Speaker driver for months - my fix for
it is included in ftp://dwmw2.robinson.cam.ac.uk/pub/kernel/patch-pcsp-2.1.88
which is (obviously) against 2.1.88, but should apply to just about anything
since 2.1.6x AFAICR.

If you've already installed the PC Speaker driver, just apply the one-liner
attached.

This applies to all 2.1 kernels - the bug only shows up in certain memory
layouts, and didn't happen to me until today.

Other than this minor aberration, this driver has now been rock solid in my SMP
system and numerous UP systems that I maintain for a long time. Could it go
into the distribution kernel, please?

--- linux2/drivers/pcsnd/pcsp_stub.c Sat Feb 21 16:21:54 1998
+++ linux/drivers/pcsnd/pcsp_stub.c Sat Feb 21 15:43:49 1998
@@ -154,7 +154,7 @@
__initfunc(static int pcsp_test_speed(void))
{
int worst, worst1, best, best1;
- unsigned char test_buffer[32];
+ unsigned char test_buffer[256];

worst = pcsp_measurement(test_buffer, 0);
worst1 = pcsp_measurement(test_buffer, 0);

---- ---- ----
David Woodhouse, Robinson College, CB3 9AN, England. (+44) 0976 658355
Dave@imladris.demon.co.uk http://dwmw2.robinson.cam.ac.uk
finger pgp@dwmw2.robinson.cam.ac.uk for PGP key.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu