ordering in enum scsi_directory_inos

Ion Badulescu (ionut@moisil.cs.columbia.edu)
Tue, 10 Feb 1998 10:06:25 -0500 (EST)


Hi,

Is there any good reason for changing the order of adapters in enum
scsi_directory_inos (proc_fs.h) between 2.0.33 and 2.1.xx? If not, I have
a good one *against*: it breaks scsidev. On one of my machines, using an
aix7xxx controller, devices in /dev/scsi show up as sdh7-xxx in 2.0.33 and
as sdh10-xxx in 2.1.85. Which obviously prevents me from dual booting
between 2.0 and 2.1 since each entry in fstab breaks.

I have attached a patch which changes the ordering back to the one in
2.0.33 and adds the new adapters to the end of the list. If there are no
objections, it would be nice to have it go into the official tree.

Comments are welcome.

Thanks,
Ionut

-- 
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.

------------------------- --- linux-2.1.85/include/linux/proc_fs.h.old Wed Feb 4 06:51:08 1998 +++ linux-2.1.85/include/linux/proc_fs.h Tue Feb 10 09:51:13 1998 @@ -137,12 +137,10 @@ PROC_NET_LAST }; +/* please add new controllers before SCSI_DEBUG __only__ */ enum scsi_directory_inos { PROC_SCSI_SCSI = 256, PROC_SCSI_ADVANSYS, - PROC_SCSI_PCI2000, - PROC_SCSI_PCI2220I, - PROC_SCSI_PSI240I, PROC_SCSI_EATA, PROC_SCSI_EATA_PIO, PROC_SCSI_AHA152X, @@ -152,7 +150,6 @@ PROC_SCSI_BUSLOGIC, PROC_SCSI_U14_34F, PROC_SCSI_FDOMAIN, - PROC_SCSI_GDTH, PROC_SCSI_GENERIC_NCR5380, PROC_SCSI_IN2000, PROC_SCSI_PAS16, @@ -160,28 +157,32 @@ PROC_SCSI_QLOGICISP, PROC_SCSI_SEAGATE, PROC_SCSI_T128, + PROC_SCSI_DC390T, PROC_SCSI_NCR53C7xx, PROC_SCSI_NCR53C8XX, PROC_SCSI_ULTRASTOR, PROC_SCSI_7000FASST, - PROC_SCSI_IBMMCA, PROC_SCSI_EATA2X, - PROC_SCSI_DC390T, PROC_SCSI_AM53C974, PROC_SCSI_SSC, PROC_SCSI_NCR53C406A, PROC_SCSI_PPA, PROC_SCSI_ESP, - PROC_SCSI_QLOGICPTI, - PROC_SCSI_AMIGA7XX, PROC_SCSI_A3000, PROC_SCSI_A2091, PROC_SCSI_GVP11, PROC_SCSI_ATARI, + PROC_SCSI_GDTH, PROC_SCSI_IDESCSI, + PROC_SCSI_QLOGICPTI, + PROC_SCSI_AMIGA7XX, PROC_SCSI_MESH, PROC_SCSI_53C94, - PROC_SCSI_SCSI_DEBUG, + PROC_SCSI_IBMMCA, + PROC_SCSI_PCI2000, + PROC_SCSI_PCI2220I, + PROC_SCSI_PSI240I, + PROC_SCSI_SCSI_DEBUG, PROC_SCSI_NOT_PRESENT, PROC_SCSI_FILE, /* I'm assuming here that we */ PROC_SCSI_LAST = (PROC_SCSI_FILE + 16) /* won't ever see more than */

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu