Re: Patch: 2.1.81: Index Configure.help(using mmap and C)

Trevor Johnson (trevor@jpj.net)
Tue, 27 Jan 1998 23:37:16 -0800 (PST)

This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.

------------B61691E0
Content-Type: TEXT/PLAIN; CHARSET=us-ascii
Content-ID: <Pine.LNX.3.96.980127225455.369C@ppp13.csudh.edu>

I tried your patch with 2.1.82. When I did "make menuconfig" I got a
new warning:

help.c:36: warning: `start_off' might be used uninitialized in this
function

I made this change, and the warning went away:

--- help.c.orig Tue Jan 27 22:52:56 1998
+++ help.c Tue Jan 27 23:03:45 1998
@@ -33,7 +33,7 @@
caddr_t hfile_mm;
FILE *ifile;
char * cur_off,*eol;
- int start_off,end_off;
+ int start_off=0,end_off;
char * config_opt=NULL;
int mode=0,temp,fs;
char * temps;

I played a bit with "make config" and "make menuconfig" and found an
anomaly: the help for CONFIG_EXPERIMENTAL disappeared.

I also noticed two snall problems which are also present in the stock
kernel (and may be beyond the scope of your patch):

--with ARCH = i386, help is available for CONFIG_M386 and the other CPUs,
but "make config" doesn't show a question mark as an option, which
elsewhere indicates that help is available.

--no help for CONFIG_BSD_PROCESS_ACCT.

Otherwise, everything seemed to work.
___
Trevor Johnson

------------B61691E0--