Re: 2.1.78 compile error

Peter J. Braam (braam@cs.cmu.edu)
Tue, 6 Jan 1998 12:51:55 -0500 (EST)


Bill,

I have just made a much bigger patch for Coda against 2.1.78. I'll send it
in right now.

Peter

On Tue, 6 Jan 1998, Bill Hawes wrote:

> kwrohrer@enteract.com wrote:
>
> > Given that the prototype is:
> > static int coda_readlink(struct dentry *dentry, char *buffer, int length);
> >
> > but the function definition starts out as:
> >
> > static int coda_readlink(struct inode *dentry, char *buffer, int length)
> > {
> > struct inode *inode = dentry->d_inode;
> >
> > "struct inode *dentry"?!? Wasn't there some warning in the Intercal
> > manual about the badness of misspelling, e.g. "reinstate" F-O-R-G-E-T?
> >
> > Apply this patch to fs/coda/symlink.c to make 2.1.78 compile with coda:
> >
> > 53c53
> > < static int coda_readlink(struct inode *dentry, char *buffer, int length)
> > ---
> > > static int coda_readlink(struct dentry *dentry, char *buffer, int length)
>
> Sorry, that was my typo in the coda routine. I made changes to pass
> dentry arguments in place of inodes for some more VFS routines, and the
> changes turned out to be rather extensive. Obviously I missed a couple
> of places ..
>
> Regards,
> Bill
>