Re: inclomplete STANDARD_MEMORY_BIOS_CALL remove in 2.1.75

Martin Mares (mj@atrey.karlin.mff.cuni.cz)
Fri, 26 Dec 1997 19:04:53 +0100


Hi,

> In patch-2.1.75 there were changes in arch/i386/kernel/setup.c, which
> obviously are incomplete:
>
> If STANDARD_MEMORY_BIOS_CALL _is_ defined, then ALT_MEM_K (PARAM+0x1e0)
> will _not_ be preset correctly. Patch 2.1.75 did remove the '#ifndef' only
> partially, so the code will not be correct.
>
> This should be cleaned up either by removing the STANDARD_MEMORY_BIOS_CALL
> code completely or by reinstalling the '#ifndef STANDARD_MEMORY_BIOS_CALL'
> in arch/i386/kernel/setup.c.

(1) I don't see ALT_MEM_K used anywhere in setup.c if STANDARD_..._CALL
is defined.

(2) Your solution with patching setup.S to set PARAM+0x1e0 to zero is
better, because we can remove the STANDARD_..._CALL ifndef from setup.c
completely.

Anyway, thanks for reporting the problem -- I don't use the old way
of detecting memory anywhere, so I didn't catch the bug before...

Have a nice fortnight

-- 
Martin `MJ' Mares   <mj@gts.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"Light-year? One-third less calories than a regular year."