Re: lp.c IEEE1284 readback patch

Philip Blundell (
Tue, 16 Dec 1997 09:02:43 +0000

>I've some additions to the "IEEE1284" compatible printer port readback in
>"nibble mode". This patch is against a 2.1.72 kernel and should apply
>without problems to the file drivers/char/lp.c and linux/include/lp.h.

Hi Carsten.

Thanks for the patch.

>Please have also a look on the added ioctl. Use this small program for a
>first test after applying the kernel patch:

I don't think this really belongs in the lp driver. I'd prefer to see it
implemented as a file in /proc that one could read. The parport_probe code
already reads the device ID data at initialisation time, so one could just
store it for future return (avoiding the load problems).

I'd also like to see some of the code that's in lp.c moved to
parport_ieee1284.c, where appropriate.