Success! (was Re: patch for 2.1.66 smbfs, smbclient)

Chris Wedgwood (chris@f00f.org)
Mon, 1 Dec 1997 01:31:34 +1300


OK... looks like this is now working.

I added some debugging to show the result of kill_proc - and for non-root
uses this does indeed fail, but for root it works every time.

The following patch to fs/smbfs/proc.c fixes this:

--- proc.c.orig Mon Dec 1 00:43:50 1997
+++ proc.c Mon Dec 1 01:21:28 1997
@@ -501,7 +501,10 @@
goto out;
}

- kill_proc(server->conn_pid, SIGUSR1, 0);
+ /* may as well use result... */
+ result = kill_proc(server->conn_pid, SIGUSR1,!0);
+ printk("smbfs: kill_proc returned %d\n",result);
+
#if 0
server->conn_pid = 0;
#endif

The other patches you sent me didn't make '67 - which is a shame because they
are pretty much necessary.

With the patches you sent me and this little one, things now seem to work
pretty well. (There a still a few minor problems to do with shares going
away and re-appearing which I'll play with when I have more time, and
generally won't happen under normal circumstances).

Thanks for all you help. Its very much appreciated.

I'm also thinking about folding smbclient into mount as some point.

-Chris