Re: 2.1.66 Oopses

Bill Hawes (whawes@star.net)
Fri, 28 Nov 1997 09:15:09 -0500


Andrew Walker wrote:
> Looks like close_fp() is handing locks_remove_locks() a file pointer
> with a NULL dentry. At the moment there are no pointer checks in
> lock_remove_locks() because this didn't used to be possible.
>
> I don't know whether locks_remove_locks() should handle this case, or
> whether to handle it before deciding to call locks_remove_locks() or
> whether perhaps it is symptomatic of a dentry problem i.e. that the NULL
> dentry is a bug in itself, not just a new case for us to handle.

File pointers aren't supposed to have NULL dentries, so it's a problem
further back somewhere. We need to track down the cause rather than
adding checks for this case.

Regards,
Bill