Re: drivers/char/misc.c

Alan Cox (alan@lxorguk.ukuu.org.uk)
Wed, 26 Nov 1997 15:34:09 +0000 (GMT)


> Is there any reason why misc_open assumes that
> all misc drivers will provide an open function?
>
>
> -- from line 119 (2.1.65)
> if ((file->f_op = c->fops))
> return file->f_op->open(inode,file);
> else
> return -ENODEV;
> --
>
> Surely it's a bit daft to miss out "&& file->f_op->open"?

Not an unreasonable change suggestion. Mail me a patch file after you've
tested it