2.1.62, smbfs and sound (fwd)

John Hayward-Warburton (linux@billabong.demon.co.uk)
Tue, 4 Nov 1997 07:28:44 +0000 (GMT)


May I report a happy 2.1.62?

Just for the record, smbfs works brilliantly at this site in 2.1.62,
talking to both Win95 and Win3.1 machines (note: there is no NT at
this site, so the possible clash with Win95 slowness and protocols
does not happen). Thank you, Bill Hawes, Volker Lendecke, etc.

The sound system (on a CS4232-based card) does not work. However, by
applying the patch for 2.1.61 issued by Anders Hammarquist
(iko@netg.se), it can be made to come back to life.

In case you didn't get it first time, here's the patch. I emphasise:
this is purely my experience, and I am sure I do not have the
definitive answer to anything. Simply, it works for me in tests
carried out here.

Hisax ISDN cards work perfectly, now. Linus has completed the
changes begun by another mailing list recipient a few days ago..

lp seems fine, too. So, that's the four problems that kept me from
upgrading from 2.1.59 fixed.

Best wishes,

John Hayward-Warburton
linux@billabong.demon.co.uk

--- linux/drivers/sound/soundcard.c~ Sun Sep 21 02:07:43 1997
+++ linux/drivers/sound/soundcard.c Sat Nov 1 01:51:50 1997
@@ -57,9 +57,10 @@


static long
-sound_read (struct inode *inode, struct file *file, char *buf, unsigned long count)
+sound_read (struct file *file, char *buf, size_t count, loff_t *ppos)
{
int dev;
+ struct inode *inode = file->f_dentry->d_inode;

dev = MINOR (inode->i_rdev);

@@ -69,9 +70,10 @@
}

static long
-sound_write (struct inode *inode, struct file *file, const char *buf, unsigned long count)
+sound_write (struct file *file, const char *buf, size_t count, loff_t *ppos)
{
int dev;
+ struct inode *inode = file->f_dentry->d_inode;

dev = MINOR (inode->i_rdev);

@@ -82,7 +84,7 @@

static long long sound_lseek (struct file *file, long long offset, int orig)
{
- return -EPERM;
+ return -ESPIPE;
}

static int