local prototype declarations

Ulrich Windl (ulrich.windl@rz.uni-regensburg.de)
Thu, 11 Sep 1997 11:39:27 +0200


I know that all of you are working hard, and it might seem
inapropriate to bring up this issue, but anyway:

I think that declaring function prototypes in a local scope is a bad
thing for anything else but ugly short-term hacks. There is no check
that the prototype will match the functions signature on the long
term. The proper ways is to include the corresponding header file.

Why I'm telling you? I thought I've seen a local prototype in
keyboard.c for allow_interrupts() or something like that in the patch

P.S: Are there any objections to move some of the timekeeping stuff
from sched.c into time.c? IMHO sched.c is already long enough...
P.P.S: I'm not subscribed here