Re: New pre-2.0.31 patches..

Trevor Johnson (trevor@jpj.net)
Tue, 5 Aug 1997 03:11:24 -0700 (PDT)


David Flood wrote:

> make menuconfig give the following errors
>
> lxdialog.c: In function `main':
> lxdialog.c:123: warning: assignment of read-only location

This is at the very end of pre-patch-2.0.31-3:

--- v2.0.30/linux/scripts/lxdialog/lxdialog.c Sun Feb 25 01:17:58 1996
+++ linux/scripts/lxdialog/lxdialog.c Sun Aug 3 15:38:39 1997
@@ -119,7 +119,8 @@
if (modePtr->argmax && argc - offset > modePtr->argmax)
Usage (argv[0]);

-
+ if (title && strlen(title) > atoi(argv[offset+4])-4)
+ title[atoi(argv[offset+4])-4] = 0;

init_dialog ();
retval = (*(modePtr->jumper)) (title, argc - offset, argv + offset);

but title has already been declared as const char *:

int
main (int argc, const char * const * argv)
{
int offset = 0, clear_screen = 0, end_common_opts = 0, retval;
const char *title = NULL;

I also noticed a new e-mail address for William Roadcap in the MAINTAINERS
file which isn't reflected in the files in the scripts/lxdialog directory.
I suppose it's not critical though. :)
___
Trevor Johnson