Re: 2.0.30 serial.c, ppp.c and pppd-2.2 questions

Bill Hawes (whawes@star.net)
Fri, 18 Jul 1997 20:56:29 -0400

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Michael Ballbach: "sysrq.c: 2.1.45"
Previous message: Daniel G. Link: "2.1.45 won't compile with ISDN enabled"
Maybe in reply to: Rob Riggs: "2.0.30 serial.c, ppp.c and pppd-2.2 questions"

Rob Riggs wrote:
> In serial.c's receive_char() interrupt handler we read a
> char from the UART then just drop it if the flip buffer
> is full.

I asked about this a while back, and the reply was that the flip buffer
is not supposed to ever fill up. The flip buffer is flipped on the
jiffy clock (e.g. 100 Hz), so it should handle serial rates far in
excess of 64kbps without filling.

The present code does appear to have some bugs if it fills -- look
closely at the logic for handling overrun indications. But if it never
fills, fixing things is not a priority.

-Bill

Next message: Michael Ballbach: "sysrq.c: 2.1.45"
Previous message: Daniel G. Link: "2.1.45 won't compile with ISDN enabled"
Maybe in reply to: Rob Riggs: "2.0.30 serial.c, ppp.c and pppd-2.2 questions"