Re: problems with compiling 2.1.45-7

James Mastros (abszero@epix.net)
Wed, 16 Jul 1997 20:25:42 -0400


At 10:13 AM 7/16/97 -0400, Bill Hawes wrote:
>Joseph Skinner wrote:
>Here's the patch I used ...
>
>-Bill--- include/linux/dcache.h.old Wed Jul 16 06:44:08 1997
>+++ include/linux/dcache.h Wed Jul 16 08:59:45 1997
>@@ -65,7 +65,7 @@
> * to invalidate a dentry for some reason (NFS
> * timeouts or autofs deletes).
> */
>-inline void d_drop(struct dentry * dentry)
>+static inline void d_drop(struct dentry * dentry)
> {
> list_del(&dentry->d_hash);
> INIT_LIST_HEAD(&dentry->d_hash);

Doesn't that mean that for a given parameter then the fn will always return
the same val, and that it has no side-effects, which is totally false here?

(Not to sound condescending, I hardly have status to be so)

-=- James Mastros