HDIO_GETGEO in 2.1.43

Russell Coker - mailing lists account (bofh@snoopy.virtual.net.au)
Wed, 16 Jul 97 18:42:16 +1100


I noticed the following when searching for the definition of HDIO_GETGEO
in the source of 2.1.43. It appears that this macro is defined in 3
different include files. Is there some reason for this?

If not then what would be the appropriate way of fixing this? Should I
create a new header file for the IOCTLs or should I have the ps2esdi.h and
xd.h files include hdreg.h?

rjc@snoopy:/usr/src/linux$find . -name "*.h" | xargs grep GETGEO | more
./include/linux/hdreg.h:#define HDIO_GETGEO 0x0301 /* get
device geometry */ ./include/linux/ps2esdi.h:#define HDIO_GETGEO 0x0301
./drivers/block/xd.h:#define HDIO_GETGEO 0x0301 /* get
drive geometry */ ./drivers/block/xd.h:/* this structure is returned to the
HDIO_GETGEO ioctl */

Russell Coker