Re: IPX socket allocation patch
Dr. Werner Fink (werner@suse.de)
Mon, 14 Jul 1997 19:53:40 +0200
> As part of the recent discussion regarding 2.0.30 I looked at
> pre-2.0.31-2 a bit more closely and found that the following patch did
> not make it in. I did not find it on www.linuxhq.com, so it might have
> been lost. Whoever makes a pre-2.0.31-3 please include it. Thanks.
>
> It fixes a very annoying and hard to find problem with hanging ipx
> sockets. If you want to know more about the symptoms, please look at
> the readme of ncpfs-2.0.10. MANY thanks to Martin Stover who finally
> found it.
>
> Volker
>
> diff -u -urN 2.0.30/net/ipx/af_ipx.c 2.0.30-patched/net/ipx/af_ipx.c
> - --- 2.0.30/net/ipx/af_ipx.c Wed Nov 27 08:44:21 1996
> +++ 2.0.30-patched/net/ipx/af_ipx.c Mon Jul 14 17:25:12 1997
> @@ -1723,6 +1723,7 @@
> }
> sk->rcvbuf=SK_RMEM_MAX;
> sk->sndbuf=SK_WMEM_MAX;
> + sk->allocation=GFP_KERNEL;
> sk->prot=NULL; /* So we use default free mechanisms */
> skb_queue_head_init(&sk->receive_queue);
> skb_queue_head_init(&sk->write_queue);
>
This patch looks against pre-patch-2.0.31-2 as the following:
--- linux-2.0.31-clean/net/ipx/af_ipx.c Tue Jun 10 12:58:49 1997
+++ linux/net/ipx/af_ipx.c Mon Jul 14 19:51:36 1997
@@ -1776,6 +1776,7 @@
}
sk->rcvbuf=SK_RMEM_MAX;
sk->sndbuf=SK_WMEM_MAX;
+ sk->allocation=GFP_KERNEL;
sk->prot=NULL; /* So we use default free mechanisms */
skb_queue_head_init(&sk->receive_queue);
skb_queue_head_init(&sk->write_queue);