Re: [2.1.36] parport_procfs.c

Horst von Brand (vonbrand@inf.utfsm.cl)
Mon, 12 May 1997 10:33:52 -0400


Wilfred Brown <wilfred@bayserve.net> wrote:

[...]

> A quick look at /usr/src/linux/include/linux/*.h shows that most (all?)
> files are properly ifdef'ed so that files are only included once. So
> you'll have to fall back on a different argument.

'Included once' means they have to be read each time, and cpp has to figure
out it has to cut them down to nothing, and cc1 has to look at each of the
resulting empty lines. No _big_ deal, really...

The point should not be "compilation time" (of which the above is a tiny
part) but "understanding time", i.e., write stuff so it is unambigous and
easy to read. Use the least amount of "black magic" behind the reader's
back (so it is better to spell out what is included where instead of .h's
that #include all kind of stuff "just in case").

IMVHO. US$0.02 from yours truly.

--
Dr. Horst H. von Brand                       mailto:vonbrand@inf.utfsm.cl
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513